Bug 244374 - Unify copies of SDKVariant.xcconfig
Summary: Unify copies of SDKVariant.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 244440 244450
  Show dependency treegraph
 
Reported: 2022-08-25 20:48 PDT by David Kilzer (:ddkilzer)
Modified: 2022-08-28 08:20 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-08-25 20:48:58 PDT
Unify copies of SDKVariant.xcconfig.

Create a `Source/Configurations` folder and move one copy of `SDKVariant.xcconfig` into it, then remove the duplicate copies, then finally fix project references to use relative paths.

The `Source/Configurations` folder is added to the WebKit.xcworkspace as well (since we can move other common files into this folder later).

We place this in `Source` instead of in the top-level folder since it will make source submissions easier at Apple.
Comment 1 Radar WebKit Bug Importer 2022-08-25 20:49:17 PDT
<rdar://problem/99169843>
Comment 2 David Kilzer (:ddkilzer) 2022-08-25 20:57:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3688
Comment 3 EWS 2022-08-26 22:26:21 PDT
Committed 253857@main (024ecd89c769): <https://commits.webkit.org/253857@main>

Reviewed commits have been landed. Closing PR #3688 and removing active labels.
Comment 4 David Kilzer (:ddkilzer) 2022-08-27 14:18:31 PDT
(In reply to David Kilzer (:ddkilzer) from comment #0)
> Unify copies of SDKVariant.xcconfig.
> 
> Create a `Source/Configurations` folder and move one copy of
> `SDKVariant.xcconfig` into it, then remove the duplicate copies, then
> finally fix project references to use relative paths.
> 
> The `Source/Configurations` folder is added to the WebKit.xcworkspace as
> well (since we can move other common files into this folder later).
> 
> We place this in `Source` instead of in the top-level folder since it will
> make source submissions easier at Apple.

FYI, the `Configurations` folder was placed at the same level as the `Source` folder since there was a simple change to `Makefile` to make source submissions work.