WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
244364
[AppSSO] Adjust life cycle of SOAuthorization to avoid premature cancellation
https://bugs.webkit.org/show_bug.cgi?id=244364
Summary
[AppSSO] Adjust life cycle of SOAuthorization to avoid premature cancellation
Brent Fulgham
Reported
2022-08-25 15:08:32 PDT
Testing has shown that attempting to share a single SOAuthorization object amongst several active sessions can lead to deadlocks during AppSSO authentication. Since the SOAuthorization object is meant to be stateless, there is no harm in constructing and destroying it for each type of authentication flow. This simplifies the logic, and makes it clear which SOAuthorization object is associated with a given load event.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2022-08-25 15:08:53 PDT
<
rdar://98413693
>
Brent Fulgham
Comment 2
2022-08-25 16:49:24 PDT
Pull request:
https://github.com/Webkit/WebKit/pull/3684
EWS
Comment 3
2022-08-29 15:43:02 PDT
Committed
253929@main
(bc90c50c6ba8): <
https://commits.webkit.org/253929@main
> Reviewed commits have been landed. Closing PR #3684 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug