Bug 244355 - Disable mini mode scavenger for apps
Summary: Disable mini mode scavenger for apps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-25 13:23 PDT by Ben Nham
Modified: 2022-08-26 18:24 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-08-25 13:23:22 PDT 
We accidentally enabled the mini mode scavenger for Safari recently due to an entitlement change. This is contributing to a regression in the power benchmarks, since the regular scavenger has a period of 100 ms while the mini mode scavenger has a period of 5 ms. We should restore the old behavior to mitigate this regression.
Comment 1 Ben Nham 2022-08-25 13:27:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3671
Comment 2 Ben Nham 2022-08-25 13:28:12 PDT 
<rdar://98989977>
Comment 3 EWS 2022-08-26 18:24:51 PDT 
Committed 253852@main (0df435b1b392): <https://commits.webkit.org/253852@main>

Reviewed commits have been landed. Closing PR #3671 and removing active labels.