RESOLVED FIXED244227
[IFC][Integration] Implement selectionState for ellipsis box 
https://bugs.webkit.org/show_bug.cgi?id=244227
Summary [IFC][Integration] Implement selectionState for ellipsis box
alan
Reported 2022-08-22 16:26:34 PDT
ssia
Attachments
Patch (13.30 KB, patch)
2022-08-22 16:33 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.46 KB, patch)
2022-08-23 07:47 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.76 KB, patch)
2022-08-23 11:05 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-08-22 16:33:35 PDT
Created attachment 461810 [details] Patch
alan
Comment 2 2022-08-23 07:47:47 PDT
Created attachment 461821 [details] Patch
Antti Koivisto
Comment 3 2022-08-23 07:52:55 PDT
Comment on attachment 461821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461821&action=review > Source/WebCore/rendering/EllipsisBoxPainter.cpp:140 > + auto pathCopy = m_ellipsisBox; > + return InlineIterator::LeafBoxIterator { WTFMove(pathCopy) }->selectionState(); Why this dance?
Antti Koivisto
Comment 4 2022-08-23 07:58:18 PDT
Comment on attachment 461821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461821&action=review > Source/WebCore/rendering/EllipsisBoxPainter.cpp:48 > +EllipsisBoxPainter<EllipsisBoxPath>::EllipsisBoxPainter(EllipsisBoxPath&& ellipsisBox, PaintInfo& paintInfo, const LayoutPoint& paintOffset, Color selectionForegroundColor, Color selectionBackgroundColor) We can probably undo the templating at some point and just use the iterator, I think it is an over-optimization.
alan
Comment 5 2022-08-23 11:05:06 PDT
Created attachment 461823 [details] Patch
alan
Comment 6 2022-08-23 11:05:43 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 461821 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461821&action=review > > > Source/WebCore/rendering/EllipsisBoxPainter.cpp:48 > > +EllipsisBoxPainter<EllipsisBoxPath>::EllipsisBoxPainter(EllipsisBoxPath&& ellipsisBox, PaintInfo& paintInfo, const LayoutPoint& paintOffset, Color selectionForegroundColor, Color selectionBackgroundColor) > > We can probably undo the templating at some point and just use the iterator, > I think it is an over-optimization. Agree!
EWS
Comment 7 2022-08-23 19:23:15 PDT
Committed 253714@main (a3119d12cba0): <https://commits.webkit.org/253714@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461823 [details].
Radar WebKit Bug Importer
Comment 8 2022-08-23 19:24:48 PDT
<rdar://problem/99062682>
Note You need to log in before you can comment on or make changes to this bug.