Bug 244205 - Fix invalid %{public} %{private} format strings in cross-platform code
Summary: Fix invalid %{public} %{private} format strings in cross-platform code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-22 08:59 PDT by Michael Catanzaro
Modified: 2022-09-06 10:04 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-08-22 08:59:10 PDT 
%{public} and %{private} are not valid format strings except on Apple platforms, and cannot be used in cross-platform code. Most uses can be replaced with the existing PUBLIC_LOG_STRING and PRIVATE_LOG_STRING.

Since not everything we log is a string, I have added PUBLIC_LOG and PRIVATE_LOG as well to allow more generic use.
Comment 1 Michael Catanzaro 2022-08-22 09:01:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3537
Comment 2 EWS 2022-09-06 10:03:58 PDT 
Committed 254189@main (3454ee99a16d): <https://commits.webkit.org/254189@main>

Reviewed commits have been landed. Closing PR #3537 and removing active labels.