Bug 244184 - [GLIB] aptIfExists always returns exit status code 0
Summary: [GLIB] aptIfExists always returns exit status code 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-22 01:55 PDT by Diego Pino
Modified: 2022-08-22 06:27 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-08-22 01:55:03 PDT 
Reported by Andrew Sutherland at https://github.com/WebKit/WebKit/pull/1323#discussion_r950626647

Function `aptIfExists` from script `Tools/glib/dependencies/atk` always return exist status code 0 since in Bash a declaration of variable that is inmediately assigned is always successful.

This error makes the script `Tools/gtk/install-depedencies` fail in systems that cannot provide a package wrapped in `aptIfExists` statement.
Comment 1 Diego Pino 2022-08-22 01:56:59 PDT 
Pull request: https://github.com/webkit/webkit/pull/3525
Comment 2 EWS 2022-08-22 06:26:07 PDT 
Committed 253643@main (0c682bc2aaaa): <https://commits.webkit.org/253643@main>

Reviewed commits have been landed. Closing PR #3525 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-08-22 06:27:15 PDT 
<rdar://problem/98978365>