Bug 244173 - [LFC][IFC] text-overflow: ellipsis should not affect geometries
Summary: [LFC][IFC] text-overflow: ellipsis should not affect geometries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-21 15:35 PDT by zalan
Modified: 2022-08-22 10:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26.60 KB, patch)
2022-08-21 15:47 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-08-21 15:35:41 PDT 
it's visual only operation.
Comment 1 zalan 2022-08-21 15:47:26 PDT 
Created attachment 461780 [details]
Patch
Comment 2 Antti Koivisto 2022-08-22 09:01:08 PDT 
Comment on attachment 461780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461780&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872
> +            if (!hasDamage(box))
> +                continue;

Maybe the hasDamage(box) test could go before all the type tests too and be done in one place only. Not sure about the inline-block case...
Comment 3 zalan 2022-08-22 10:01:45 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 461780 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461780&action=review
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872
> > +            if (!hasDamage(box))
> > +                continue;
> 
> Maybe the hasDamage(box) test could go before all the type tests too and be
> done in one place only. Not sure about the inline-block case...
good point. will do in a followup patch.
Comment 4 EWS 2022-08-22 10:42:09 PDT 
Committed 253650@main (dfaf8254ed07): <https://commits.webkit.org/253650@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461780 [details].
Comment 5 Radar WebKit Bug Importer 2022-08-22 10:43:16 PDT 
<rdar://problem/98988623>