Bug 244108 - [webkitpy] Make SimulatedDevice.is_usable check more accurate
Summary: [webkitpy] Make SimulatedDevice.is_usable check more accurate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dawn Morningstar
URL:
Keywords: InRadar
: 244908 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-08-18 16:56 PDT by Dawn Morningstar
Modified: 2022-09-07 19:52 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawn Morningstar 2022-08-18 16:56:51 PDT 
Rather than use a service for checking if the device is in a usable state, attempt to boot an app and if the app boots then terminate it and report that it is usable. This change is because the services are reporting aas alive before the device is usable but launching an app will only succesfully happen if a device iss actually usable. I have tested this change on iOS, iPad and watchOS and it works sucessfully on local testing.
Comment 1 Dawn Morningstar 2022-08-18 16:58:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3467
Comment 2 Radar WebKit Bug Importer 2022-08-18 17:08:21 PDT 
<rdar://problem/98857256>
Comment 3 EWS 2022-08-26 16:07:40 PDT 
Committed 253846@main (38e1eb990499): <https://commits.webkit.org/253846@main>

Reviewed commits have been landed. Closing PR #3467 and removing active labels.
Comment 4 Dawn Morningstar 2022-09-07 14:53:25 PDT 
*** Bug 244908 has been marked as a duplicate of this bug. ***
Comment 5 Dawn Morningstar 2022-09-07 15:13:14 PDT 
Re-opening for pull request https://github.com/apple/WebKit/pull/47
Comment 6 EWS 2022-09-07 19:52:25 PDT 
Committed 252432.355@safari-7614-branch (2599c44c6101): <https://commits.webkit.org/252432.355@safari-7614-branch>

Reviewed commits have been landed. Closing PR #47 and removing active labels.