Bug 244041 - [JSC] Adobe website crashes on mini browser when JITting with O2
Summary: [JSC] Adobe website crashes on mini browser when JITting with O2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yijia Huang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-17 09:50 PDT by Yijia Huang
Modified: 2022-08-22 23:05 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yijia Huang 2022-08-17 09:50:55 PDT
Website https://lightroom.adobe.com/learn/tutorial/cf323dc7-5d20-4bb1-8249-616995c41800 crashes on minibrowser when running command
```
__XPC_JSC_validateOptions=1 __XPC_JSC_useWasmLLInt=0 __XPC_JSC_useOMGJIT=0 __XPC_JSC_wasmBBQUsesAir=0 __XPC_JSC_webAssemblyBBQB3OptimizationLevel=2 __XPC_JSC_useBBQTierUpChecks=0 ./Tools/Scripts/run-minibrowser
```

It crashes on function effectiveAddr in B3LowerToAir.cpp when`ASSERT(Arg::isValidAddrForm(offset, width));`in debug mode. A temp fix could be  

```
        // ASSERT(Arg::isValidAddrForm(offset, width));

        if (!Arg::isValidAddrForm(offset, width)) {
            Tmp a = m_code.newTmp(GP);
            append(Air::Move, Arg::bigImm(offset), a);
            append(Air::Add64, tmp(address), a, a);
            return Arg::addr(a);
        }
    
```
Comment 1 Yijia Huang 2022-08-22 17:03:25 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3509
Comment 2 EWS 2022-08-22 23:04:40 PDT
Committed 253670@main (50d540abca1b): <https://commits.webkit.org/253670@main>

Reviewed commits have been landed. Closing PR #3509 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-08-22 23:05:28 PDT
<rdar://problem/99017185>