Description: editing/pasteboard/4944770-2.html The test is a consistent failure on iOS and a consistent crash on macOS Debug. REPRODUCTION STEPS I can reproduce this on 253429@main but cannot reproduce it on 253428@main or earlier. Command: [iOS] run-webkit-tests --ios-simulator --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 --no-retry editing/pasteboard/4944770-2.html [macOS Debug] run-webkit-tests --debug --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry editing/pasteboard/4944770-2.html [iOS] Result: Regressions: Unexpected text-only failures (1) editing/pasteboard/4944770-2.html [ Failure ] [macOS Debug] Result: Regressions: Unexpected crashes (1) editing/pasteboard/4944770-2.html [ Crash ] History: https://results.webkit.org/?suite=layout-tests&test=editing%2Fpasteboard%2F4944770-2.html&platform=ios&platform=mac&limit=50000 [iOS] Diff: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-arm64-WK2-Tests/253430@main%20(400)/editing/pasteboard/4944770-2-diff.txt [macOS Debug] Crash Log: 2022-08-16 06:17:07.759 DumpRenderTree[93427:7591065] nil host used in call to allowsSpecificHTTPSCertificateForHost 2022-08-16 06:17:07.759 DumpRenderTree[93427:7591065] nil host used in call to allowsAnyHTTPSCertificateForHost: 2022-08-16 06:17:07.865 DumpRenderTree[93427:7591065] 'NeXT smart paste pasteboard type' is not a valid UTI string. Cannot set data for an invalid UTI. ASSERTION FAILED: !((anchorType == PositionIsBeforeChildren || anchorType == PositionIsAfterChildren) && (is<Text>(*m_anchorNode) || editingIgnoresContent(*m_anchorNode))) dom/Position.cpp(127) : WebCore::Position::Position(WebCore::Node *, WebCore::Position::AnchorType) 1 0x11e5ba0a9 WTFCrash 2 0x12deaeefb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1318e4c61 WebCore::Position::Position(WebCore::Node*, WebCore::Position::AnchorType) 4 0x1318e4c93 WebCore::Position::Position(WebCore::Node*, WebCore::Position::AnchorType) 5 0x12ed81cd9 WebCore::firstPositionInNode(WebCore::Node*) 6 0x131ac1394 WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline(WebCore::ReplaceSelectionCommand::InsertedNodes&)::$_0::operator()() const 7 0x131ac0a3e WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline(WebCore::ReplaceSelectionCommand::InsertedNodes&) 8 0x131ac4bbc WebCore::ReplaceSelectionCommand::doApply() 9 0x1319f299f WebCore::CompositeEditCommand::apply() 10 0x131a4f3d5 WebCore::Editor::replaceSelectionWithFragment(WebCore::DocumentFragment&, WebCore::Editor::SelectReplacement, WebCore::Editor::SmartReplace, WebCore::Editor::MatchStyle, WebCore::EditAction, WebCore::MailBlockquoteHandling) 11 0x131a4ef82 WebCore::Editor::handleTextEvent(WebCore::TextEvent&) 12 0x132653e28 WebCore::EventHandler::defaultTextInputEventHandler(WebCore::TextEvent&) 13 0x1318c3990 WebCore::Node::defaultEventHandler(WebCore::Event&) 14 0x131819dd5 WebCore::callDefaultEventHandlersInBubblingOrder(WebCore::Event&, WebCore::EventPath const&) 15 0x131819558 WebCore::EventDispatcher::dispatchEvent(WebCore::Node&, WebCore::Event&) 16 0x1318c321d WebCore::Node::dispatchEvent(WebCore::Event&) 17 0x131a513e7 WebCore::Editor::pasteAsFragment(WTF::Ref<WebCore::DocumentFragment, WTF::RawPtrTraits<WebCore::DocumentFragment> >&&, bool, bool, WebCore::MailBlockquoteHandling, WebCore::EditAction) 18 0x12eedf299 WebCore::Editor::pasteWithPasteboard(WebCore::Pasteboard*, WTF::OptionSet<WebCore::Editor::PasteOption>) 19 0x131a580ef WebCore::Editor::paste(WebCore::Pasteboard&, WebCore::Editor::FromMenuOrKeyBinding) 20 0x131a57fa2 WebCore::Editor::paste(WebCore::Editor::FromMenuOrKeyBinding) 21 0x131a88415 WebCore::executePaste(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) 22 0x131a59f44 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const 23 0x131707489 WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) 24 0x12eb19359 WebCore::jsDocumentPrototypeFunction_execCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*) 25 0x12eb18cee long long WebCore::IDLOperation<WebCore::JSDocument>::call<&(WebCore::jsDocumentPrototypeFunction_execCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) 26 0x12eb01b64 WebCore::jsDocumentPrototypeFunction_execCommand(JSC::JSGlobalObject*, JSC::CallFrame*) 27 0x4ea2f4e0c038 28 0x11ecb1179 llint_entry 29 0x11ec8cc60 vmEntryToJavaScript 30 0x11fcf9062 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 31 0x11fcf877a JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
<rdar://problem/98737538>
Created attachment 461678 [details] Crash Log
Test gardening commit 253480@main (3af87b07a35d): <https://commits.webkit.org/253480@main> Reviewed commits have been landed. Closing PR #3371 and removing active labels.
Pull request: https://github.com/WebKit/WebKit/pull/3382
Committed 253539@main (74a899af9ecd): <https://commits.webkit.org/253539@main> Reviewed commits have been landed. Closing PR #3382 and removing active labels.
(In reply to Chris Dumez from comment #4) > Pull request: https://github.com/WebKit/WebKit/pull/3382 After landing 253539@main, the test went from crash to failure on macOS Debug. Diff: --- /Volumes/Data/worker/Apple-Monterey-Debug-WK2-Tests/build/layout-test-results/editing/pasteboard/4944770-2-expected.txt +++ /Volumes/Data/worker/Apple-Monterey-Debug-WK2-Tests/build/layout-test-results/editing/pasteboard/4944770-2-actual.txt @@ -13,7 +13,13 @@ RenderBlock (anonymous) at (0,0) size 38x18 RenderText at (8,2) size 6x13 text run at (8,2) width 6: "1" - RenderBlock {DIV} at (0,70) size 784x18 - RenderText {#text} at (0,0) size 16x18 - text run at (0,0) width 16: "xx" -caret: position 1 of child 0 {#text} of child 4 {DIV} of body + RenderBlock {DIV} at (0,70) size 784x19 + RenderText {#text} at (0,0) size 30x18 + text run at (0,0) width 30: "xfoo" + RenderMenuList {SELECT} at (29,1) size 39x18 [bgcolor=#FFFFFF] + RenderBlock (anonymous) at (0,0) size 38x18 + RenderText at (8,2) size 6x13 + text run at (8,2) width 6: "1" + RenderText {#text} at (67,0) size 9x18 + text run at (67,0) width 9: "x" +caret: position 3 of child 1 {SELECT} of child 4 {DIV} of body Do any changes need to be made, or is this just a re-baseline?
Reopened to verify the fix.
Upon further review after landing 253539@main, the test went from crash to failure on macOS wk2 only. History: https://results.webkit.org/?suite=layout-tests&test=editing%2Fpasteboard%2F4944770-2.html&platform=mac&limit=50000&flavor=wk2&flavor=gpuprocess
(In reply to Karl Rackler from comment #8) > Upon further review after landing 253539@main, the test went from crash to > failure on macOS wk2 only. > > History: > https://results.webkit.org/?suite=layout- > tests&test=editing%2Fpasteboard%2F4944770-2. > html&platform=mac&limit=50000&flavor=wk2&flavor=gpuprocess The test was passing on Mac-wk2 for me locally, maybe because I am on Ventura Beta. Anyway, I did a rebaseline based on the output from the bot: https://commits.webkit.org/253558@main