Bug 243985 - Cocoa code in WebKit/Source/Platform is not available in C++ unit tests
Summary: Cocoa code in WebKit/Source/Platform is not available in C++ unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 244267
Blocks: 243780
  Show dependency tree / graph
 
Reported: 2022-08-16 03:33 PDT by Kimmo Kinnunen
Modified: 2022-08-25 23:44 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-08-16 03:33:43 PDT 
Cocoa code in WebKit/Source/Platform is not available in C++ unit tests
Comment 1 Radar WebKit Bug Importer 2022-08-16 03:35:38 PDT 
<rdar://problem/98715202>
Comment 2 Kimmo Kinnunen 2022-08-16 04:52:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3359
Comment 3 EWS 2022-08-22 23:14:22 PDT 
Committed 253671@main (154ff0da5bbd): <https://commits.webkit.org/253671@main>

Reviewed commits have been landed. Closing PR #3359 and removing active labels.
Comment 4 WebKit Commit Bot 2022-08-23 13:34:47 PDT 
Re-opened since this is blocked by bug 244267
Comment 5 Ryan Haddad 2022-08-23 14:49:23 PDT 
Reverted in https://commits.webkit.org/253699@main because it broke builds with PGO.
Comment 6 Kimmo Kinnunen 2022-08-25 00:11:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3644
Comment 7 EWS 2022-08-25 23:44:07 PDT 
Committed 253808@main (88d1b92d0f9f): <https://commits.webkit.org/253808@main>

Reviewed commits have been landed. Closing PR #3644 and removing active labels.