Bug 243983 - [GTK][WPE] Improve the application icon passed to notification service
Summary: [GTK][WPE] Improve the application icon passed to notification service
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2022-08-16 02:47 PDT by Carlos Garcia Campos
Modified: 2022-08-16 06:00 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-08-16 02:47:39 PDT 
We currently check if the app icon is in the gtk theme to send the name. That only works for GTK and apps having an icon in the theme. We can also check if the application has a desktop file and get the icon from there.
Comment 1 Carlos Garcia Campos 2022-08-16 02:52:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3355
Comment 2 EWS 2022-08-16 06:00:13 PDT 
Committed 253464@main (da53f062a9f1): <https://commits.webkit.org/253464@main>

Reviewed commits have been landed. Closing PR #3355 and removing active labels.