Bug 243927 - WebAccessibilityObjectWrapperBase m_isolatedObject and m_axObject should have stronger types than AXCoreObject
Summary: WebAccessibilityObjectWrapperBase m_isolatedObject and m_axObject should have...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-14 10:48 PDT by Tyler Wilcock
Modified: 2022-08-14 16:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.37 KB, patch)
2022-08-14 10:52 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-08-14 10:48:20 PDT 
These member variables are clearly intended to contain a live object (AccessibilityObject) and isolated object (AXIsolatedObject) respectively, and they should be typed as such so we can avoid accidentally assigning the wrong object to each variable. This also makes future refactors easier (e.g. https://bugs.webkit.org/show_bug.cgi?id=243920) reducing the amount of casting required.
Comment 1 Radar WebKit Bug Importer 2022-08-14 10:48:30 PDT 
<rdar://problem/98641827>
Comment 2 Tyler Wilcock 2022-08-14 10:52:12 PDT 
Created attachment 461621 [details]
Patch
Comment 3 EWS 2022-08-14 16:02:01 PDT 
Committed 253413@main (675f5f8225a9): <https://commits.webkit.org/253413@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461621 [details].