Bug 243781 - [GStreamer] REGRESSION(253289@main): Broke debug builds
Summary: [GStreamer] REGRESSION(253289@main): Broke debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-10 05:11 PDT by Adrian Perez
Modified: 2022-08-10 08:18 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-08-10 05:11:19 PDT 
/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/Ref.h:119:52: error: invalid argument type 'WebCore::VideoFrameGStreamer' to unary expression
    bool operator!() const { ASSERT(m_ptr); return !*m_ptr; }
                                                   ^~~~~~~
/app/webkit/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:195:5: note: in instantiation of member function 'WTF::Ref<WebCore::VideoFrameGStreamer>::operator!' requested here
    ASSERT(newVideoFrame);
    ^
Comment 1 Adrian Perez 2022-08-10 05:12:38 PDT 
I suppose the assertion should be moved into PLATFORM(COCOA). Another option
would be to explicitly declare the variable as RefPtr<VideFrameGStreamer> instead of using “auto” to avoid the compiler deducing it can use Ref<T>.
I am not sure what option is preferred in this case.
Comment 2 Adrian Perez 2022-08-10 05:41:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3190
Comment 3 Philippe Normand 2022-08-10 06:16:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3192
Comment 4 EWS 2022-08-10 08:17:52 PDT 
Committed 253296@main (ec1e02abd6f9): <https://commits.webkit.org/253296@main>

Reviewed commits have been landed. Closing PR #3192 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2022-08-10 08:18:16 PDT 
<rdar://problem/98451754>