Bug 243748 - [Filters] Move the static createEffect functions to the FilterOperation classes
Summary: [Filters] Move the static createEffect functions to the FilterOperation classes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-09 13:19 PDT by Said Abou-Hallawa
Modified: 2022-08-16 13:20 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-08-09 13:19:24 PDT
The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static createEffect functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call createReferenceFilter() from CSSFilter::buildFilterFunctions() as a special case.
Comment 1 Said Abou-Hallawa 2022-08-09 13:35:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3165
Comment 2 Radar WebKit Bug Importer 2022-08-16 13:20:34 PDT
<rdar://problem/98745167>