RESOLVED FIXED243741
[Filters] Move the static calculateOutsets functions to the FilterOperation classes
https://bugs.webkit.org/show_bug.cgi?id=243741
Summary [Filters] Move the static calculateOutsets functions to the FilterOperation c...
Said Abou-Hallawa
Reported 2022-08-09 11:54:22 PDT
The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static calculateOutsets functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call calculateReferenceFilterOutsets() from CSSFilter::calculateOutsets() as a special case.
Attachments
Said Abou-Hallawa
Comment 1 2022-08-09 12:05:34 PDT
EWS
Comment 2 2022-08-09 22:49:28 PDT
Committed 253283@main (831f062e4ac0): <https://commits.webkit.org/253283@main> Reviewed commits have been landed. Closing PR #3160 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-08-09 22:50:18 PDT
Note You need to log in before you can comment on or make changes to this bug.