Bug 243737 - Fix assertion when closing a window on macOS with UI-side compositing enabled
Summary: Fix assertion when closing a window on macOS with UI-side compositing enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-09 11:08 PDT by Simon Fraser (smfr)
Modified: 2022-08-09 13:56 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-08-09 11:08:29 PDT 
We hit
     ASSERT(m_timersWereStopped);
in ~ScrollingEffectsController() because we never called ScrollingEffectsController::stopAllTimers()
Comment 1 Simon Fraser (smfr) 2022-08-09 11:11:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3157
Comment 2 EWS 2022-08-09 13:55:33 PDT 
Committed 253269@main (657e5c2cc8f4): <https://commits.webkit.org/253269@main>

Reviewed commits have been landed. Closing PR #3157 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-08-09 13:56:17 PDT 
<rdar://problem/98404117>