WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
243699
Enable os_signposts on all builds
https://bugs.webkit.org/show_bug.cgi?id=243699
Summary
Enable os_signposts on all builds
Ben Nham
Reported
2022-08-08 16:42:08 PDT
Currently WebKit's os_signposts are only enabled on AppleInternal builds. The idea was that sensitive content might be included in the signposts which should only be logged on internal builds. But this is the wrong way of achieving that goal, as we can use the standard logging privacy specifiers to control content that should be redacted from signposts. This also makes it hard to enable the signposts on perf test bots that emulate standard OS builds.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-08-08 16:42:26 PDT
<
rdar://problem/98348637
>
Ben Nham
Comment 2
2022-08-08 16:49:59 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/3125
EWS
Comment 3
2022-08-12 11:56:59 PDT
Committed
253387@main
(860f2d7753d1): <
https://commits.webkit.org/253387@main
> Reviewed commits have been landed. Closing PR #3125 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug