Bug 243691 - `git webkit pr` workflow needs to be friendlier for new contributors
Summary: `git webkit pr` workflow needs to be friendlier for new contributors
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 13
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-08-08 14:23 PDT by Ryan Haddad
Modified: 2022-08-10 17:55 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-08-08 14:23:54 PDT 
When a brand new contributor prepares their first patch and runs `git webkit pr`, they are greeted by some error messages that make it seem like things went wrong.

For one, without edit-bugs privileges in bugzilla, they will see errors about being unable to update the bugzilla (which is related to self-assigning the bug), even though the PR comment is added successfully.

Another error comes from the script attempting to add labels to the PR, which will fail because they are not in the @WebKit/contributors, which is gated on being in contributors.json.


At minimum, we should make friendlier, more informative warning messages about the above cases that don't make it look like something has gone wrong.
Comment 1 Radar WebKit Bug Importer 2022-08-08 14:24:16 PDT 
<rdar://problem/98341121>