Bug 243680 - Apply C++ type safety to Lookup.h's HashTableValue's ValueStorage union.
Summary: Apply C++ type safety to Lookup.h's HashTableValue's ValueStorage union.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-08 12:15 PDT by Mark Lam
Modified: 2022-08-14 16:57 PDT (History)
18 users (show)

See Also:

Attachments
WIP for EWS testing. (102.96 KB, patch)
2022-08-08 12:16 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP for EWS testing. (575.98 KB, patch)
2022-08-08 12:30 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
WIP for EWS testing. (577.87 KB, patch)
2022-08-08 12:52 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
WIP for EWS testing. (577.89 KB, patch)
2022-08-08 12:58 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (608.26 KB, patch)
2022-08-09 22:26 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (609.26 KB, patch)
2022-08-09 23:16 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (605.03 KB, patch)
2022-08-10 11:15 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (605.13 KB, patch)
2022-08-10 11:51 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (593.12 KB, patch)
2022-08-10 15:10 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (613.32 KB, patch)
2022-08-13 13:44 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (595.45 KB, patch)
2022-08-13 14:03 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS testing. (597.47 KB, patch)
2022-08-13 23:49 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-08-08 12:15:18 PDT 
This will help make the code cleaner and easier to reason about.
Comment 1 Mark Lam 2022-08-08 12:16:58 PDT 
Created attachment 461487 [details]
WIP for EWS testing.
Comment 2 Mark Lam 2022-08-08 12:30:53 PDT 
Created attachment 461488 [details]
WIP for EWS testing.
Comment 3 Mark Lam 2022-08-08 12:52:19 PDT 
Created attachment 461489 [details]
WIP for EWS testing.
Comment 4 Mark Lam 2022-08-08 12:58:01 PDT 
Created attachment 461490 [details]
WIP for EWS testing.
Comment 5 Mark Lam 2022-08-08 14:12:15 PDT 
<rdar://problem/98206776>
Comment 6 Mark Lam 2022-08-08 14:53:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3118
Comment 7 Mark Lam 2022-08-09 22:26:35 PDT 
Created attachment 461521 [details]
EWS testing.
Comment 8 Mark Lam 2022-08-09 23:16:40 PDT 
Created attachment 461522 [details]
EWS testing.
Comment 9 Mark Lam 2022-08-10 11:15:19 PDT 
Created attachment 461532 [details]
EWS testing.
Comment 10 Mark Lam 2022-08-10 11:51:05 PDT 
Created attachment 461535 [details]
EWS testing.
Comment 11 Mark Lam 2022-08-10 15:10:54 PDT 
Created attachment 461538 [details]
EWS testing.
Comment 12 Mark Lam 2022-08-13 13:44:19 PDT 
Created attachment 461597 [details]
EWS testing.
Comment 13 Mark Lam 2022-08-13 14:03:47 PDT 
Created attachment 461598 [details]
EWS testing.
Comment 14 Mark Lam 2022-08-13 23:49:49 PDT 
Created attachment 461605 [details]
EWS testing.
Comment 15 EWS 2022-08-14 16:57:48 PDT 
Committed 253414@main (757f991622c7): <https://commits.webkit.org/253414@main>

Reviewed commits have been landed. Closing PR #3118 and removing active labels.