Bug 243525 - Fix rounding for rgb channels in parseColorIntOrPercentage
Summary: Fix rounding for rgb channels in parseColorIntOrPercentage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-03 18:35 PDT by Tim Nguyen (:ntim)
Modified: 2022-10-21 14:04 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-08-03 18:35:57 PDT 
css/css-color/t422-rgba-a0.6-a.xht
css/css-color/t422-rgba-onscreen-b.xht
css/css-color/t422-rgba-onscreen-multiple-boxes-c.xht

css/css-color/t425-hsla-basic-a.xht
css/css-color/t425-hsla-onscreen-b.xht
css/css-color/t425-hsla-onscreen-multiple-boxes-c.xht

"Test that rgba() does not behave like opacity and draw in an offscreen buffer." is the assert that comes up in those tests.
Comment 1 Radar WebKit Bug Importer 2022-08-03 18:36:16 PDT 
<rdar://problem/98091263>
Comment 2 Tim Nguyen (:ntim) 2022-10-20 13:11:35 PDT 
css/css-color/t425-hsla-basic-a.xht was fixed as part of https://github.com/web-platform-tests/wpt/pull/36575
Comment 3 Tim Nguyen (:ntim) 2022-10-20 13:48:06 PDT 
css/css-color/t422-rgba-a0.6-a.xht was fixed by https://github.com/web-platform-tests/wpt/pull/36577
Comment 4 Tim Nguyen (:ntim) 2022-10-20 23:19:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5623
Comment 5 EWS 2022-10-21 14:04:07 PDT 
Committed 255848@main (8070eaf88efe): <https://commits.webkit.org/255848@main>

Reviewed commits have been landed. Closing PR #5623 and removing active labels.