Bug 243470 - [ews-build] Improve error message when Merge-Queue fails to find reviewer
Summary: [ews-build] Improve error message when Merge-Queue fails to find reviewer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-02 15:10 PDT by Aakash Jain
Modified: 2022-08-24 14:28 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-08-02 15:10:04 PDT 
In https://ews-build.webkit.org/#/builders/74/builds/2040 failed and complaint that "Commit message contains (OOPS!)". However, it was expected that commit message would have OOPS in it, since PR was approved throughGitHub UI, and Merge-Queue should instead remove the OOPS. We should improve the error message when Merge-Queue fails to find reviewer.
Comment 1 Aakash Jain 2022-08-03 06:50:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2976
Comment 2 EWS 2022-08-03 10:40:48 PDT 
Committed 253083@main (fd260f7fe6d3): <https://commits.webkit.org/253083@main>

Reviewed commits have been landed. Closing PR #2976 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-08-03 10:41:32 PDT 
<rdar://problem/98062999>
Comment 4 Aakash Jain 2022-08-04 04:36:46 PDT 
Working fine. e.g.: https://ews-build.webkit.org/#/builders/74/builds/2175
GitHub comment is also updated to indicate missing reviewer now: https://github.com/WebKit/WebKit/pull/2417#issuecomment-1205136296