Bug 243436 - History items added by the client app should never be skipped on back/forward navigation
Summary: History items added by the client app should never be skipped on back/forward...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-01 16:40 PDT by Chris Dumez
Modified: 2022-08-02 15:24 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-08-01 16:40:07 PDT 
History items added by the client app should never be skipped on back/forward navigation. We currently skip HistoryItems that were added without a user gesture. However, we only meant to skip the ones created by JavaScript, not the ones triggered by the client application (e.g. via [WKWebView loadRequest:]).
Comment 1 Chris Dumez 2022-08-01 16:40:14 PDT 
<rdar://97916835>
Comment 2 Chris Dumez 2022-08-01 18:06:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2934
Comment 3 EWS 2022-08-02 15:24:11 PDT 
Committed 253056@main (eb709d764c43): <https://commits.webkit.org/253056@main>

Reviewed commits have been landed. Closing PR #2934 and removing active labels.