Bug 243221 - [XCBuild] Legacy build system cleanup
Summary: [XCBuild] Legacy build system cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on: 253301
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-26 11:43 PDT by Elliott Williams
Modified: 2023-03-29 13:30 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-07-26 11:43:03 PDT
There are a number of build settings, script phases, and workarounds which only existed to support the legacy build system. Let's clean them up.

For the most part, this can be done by finding usage of WK_WHICH_BUILD_SYSTEM and WK_USE_NEW_BUILD_SYSTEM in xcconfigs and script phases, and deleting the legacy code path.
Comment 1 Elliott Williams 2022-07-26 11:45:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2745
Comment 2 Elliott Williams 2022-07-26 11:50:16 PDT
rdar://89701972
Comment 3 Radar WebKit Bug Importer 2022-07-26 11:50:25 PDT
<rdar://problem/97618431>
Comment 4 EWS 2022-07-27 10:32:16 PDT
Committed 252870@main (f5950aef5b7e): <https://commits.webkit.org/252870@main>

Reviewed commits have been landed. Closing PR #2745 and removing active labels.
Comment 5 Alex Christensen 2022-07-27 11:54:24 PDT
Reverting in https://bugs.webkit.org/show_bug.cgi?id=243259 because it broke the iOS build

make release ARCHS=arm64e SDKROOT=iphoneos.internal
Comment 6 Alex Christensen 2022-07-27 11:55:25 PDT
Reverted by https://github.com/WebKit/WebKit/pull/2787
Comment 7 EWS 2022-07-27 12:53:43 PDT
Committed 252875@main (a790b3beee52): <https://commits.webkit.org/252875@main>

Reviewed commits have been landed. Closing PR #2787 and removing active labels.
Comment 8 Elliott Williams 2023-02-22 17:31:55 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/10552
Comment 9 EWS 2023-02-27 12:42:38 PST
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
Comment 10 EWS 2023-03-02 16:37:02 PST
Committed 261111@main (91b246244bf1): <https://commits.webkit.org/261111@main>

Reviewed commits have been landed. Closing PR #10552 and removing active labels.
Comment 11 WebKit Commit Bot 2023-03-03 02:13:02 PST
Re-opened since this is blocked by bug 253301
Comment 12 Alexey Proskuryakov 2023-03-05 11:31:12 PST
rdar://89701972
Comment 13 Elliott Williams 2023-03-27 09:18:43 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12010
Comment 14 EWS 2023-03-27 11:10:43 PDT
Committed 262162@main (ecef01756ff9): <https://commits.webkit.org/262162@main>

Reviewed commits have been landed. Closing PR #12010 and removing active labels.
Comment 15 Elliott Williams 2023-03-29 12:08:16 PDT
Reopening to fix some additional places where these variables are used.
Comment 16 Elliott Williams 2023-03-29 12:19:20 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12125
Comment 17 EWS 2023-03-29 13:30:03 PDT
Committed 262287@main (dbd94e530aea): <https://commits.webkit.org/262287@main>

Reviewed commits have been landed. Closing PR #12125 and removing active labels.