Bug 243053 - Import css/css-sizing/aspect-ratio tests from WPT
Summary: Import css/css-sizing/aspect-ratio tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-21 07:11 PDT by Rob Buis
Modified: 2022-07-21 14:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (62.03 KB, patch)
2022-07-21 07:14 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (62.37 KB, patch)
2022-07-21 09:33 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-07-21 07:11:23 PDT 
Import css/css-sizing/aspect-ratio tests from WPT.
Comment 1 Rob Buis 2022-07-21 07:14:56 PDT 
Created attachment 461114 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-07-21 08:54:20 PDT 
r=me if EWS is happy
Comment 3 Tim Nguyen (:ntim) 2022-07-21 08:55:35 PDT 
Comment on attachment 461114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461114&action=review

> LayoutTests/TestExpectations:4609
>  #  contain-intrinsic-size

Is this the correct category?
Comment 4 Rob Buis 2022-07-21 09:31:30 PDT 
Comment on attachment 461114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461114&action=review

>> LayoutTests/TestExpectations:4609
>>  #  contain-intrinsic-size
> 
> Is this the correct category?

This section is a bit unstructured. The comment was made in the spirit of, if we support contain-intrinsic-size we will pass most of these aspect-ratio tests listed here (but not all since some do not use contain-intrinsic-size). As you can see the next block is actual contain-intrinsic-size directory. I'll update this before landing.
Comment 5 Rob Buis 2022-07-21 09:33:57 PDT 
Created attachment 461116 [details]
Patch
Comment 6 EWS 2022-07-21 14:17:47 PDT 
Committed 252707@main (806774691444): <https://commits.webkit.org/252707@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461116 [details].
Comment 7 Radar WebKit Bug Importer 2022-07-21 14:18:17 PDT 
<rdar://problem/97399497>