Make accessibility/accessibility-node-reparent.html so it can pass in ITM
<rdar://problem/97353412>
Created attachment 461068 [details] Patch
(In reply to Tyler Wilcock from comment #2) > Created attachment 461068 [details] > Patch --- a/LayoutTests/accessibility/accessibility-node-reparent.html +++ a/LayoutTests/accessibility/accessibility-node-reparent.html +<div id="container" role="group" tabindex="-1"></div> <canvas id="canvas" tabindex="-1"></canvas> Do we need the tabindex attribute? + // Create an ordinary button on the page, focus it and get its accessibility role. We are no longer focusing the button. + return expectedButtonRole !== expectedDetachedRole Missing ;
(In reply to Andres Gonzalez from comment #3) > (In reply to Tyler Wilcock from comment #2) > > Created attachment 461068 [details] > > Patch > > --- a/LayoutTests/accessibility/accessibility-node-reparent.html > +++ a/LayoutTests/accessibility/accessibility-node-reparent.html > > +<div id="container" role="group" tabindex="-1"></div> > > <canvas id="canvas" tabindex="-1"></canvas> > > Do we need the tabindex attribute? We do need it just for the <canvas> element to make it focusable via JS to prevent it from being ignored (which this test relies on). I removed tabindex from the <div> and applied your other comments.
Created attachment 461140 [details] Patch
Committed 252756@main (d1c30db15e8f): <https://commits.webkit.org/252756@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461140 [details].