Bug 242972 - Fix webkitpy error: 'NoneType' object has no attribute 'handle_script_error'
Summary: Fix webkitpy error: 'NoneType' object has no attribute 'handle_script_error'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-20 17:59 PDT by Aakash Jain
Modified: 2022-07-21 08:36 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-07-20 17:59:06 PDT
Noticed this error while webkitbot was trying to revert old commit (containing changelog).

Traceback (most recent call last):
  File "/var/lib/webkitbot/BotWebKit/Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "/var/lib/webkitbot/BotWebKit/Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/var/lib/webkitbot/BotWebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/var/lib/webkitbot/BotWebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/var/lib/webkitbot/BotWebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/var/lib/webkitbot/BotWebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 85, in run_and_handle_errors
    command.handle_script_error(tool, state, e)
AttributeError: 'NoneType' object has no attribute 'handle_script_error'
Comment 1 Aakash Jain 2022-07-21 04:30:11 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2615
Comment 2 EWS 2022-07-21 08:35:05 PDT
Committed 252690@main (0eeb2156b943): <https://commits.webkit.org/252690@main>

Reviewed commits have been landed. Closing PR #2615 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-21 08:36:16 PDT
<rdar://problem/97382374>