Bug 242963 - [git-webkit] Handle PR commit made on alternate remote branch
Summary: [git-webkit] Handle PR commit made on alternate remote branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-20 15:10 PDT by Jonathan Bedard
Modified: 2022-07-20 20:48 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-07-20 15:10:59 PDT
git-webkit does a good job handling commits made on `main` and then converted to PRs, but if a commit is made on a branch managed by an alternate remote, it won't be able to determine the remote from the branch point. In general, this is actually a somewhat difficult problem because the same branch may be owned by multiple remotes in various states of up-to-dateness. We want to make a PR agains the most up-to-date of the remotes which are tracking the branch we madde a commit on.
Comment 1 Radar WebKit Bug Importer 2022-07-20 15:12:27 PDT
<rdar://problem/97342489>
Comment 2 Jonathan Bedard 2022-07-20 15:14:05 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2598
Comment 3 EWS 2022-07-20 20:27:20 PDT
Committed 252678@main (54f435f6ef9f): <https://commits.webkit.org/252678@main>

Reviewed commits have been landed. Closing PR #2598 and removing active labels.
Comment 4 Jonathan Bedard 2022-07-20 20:40:57 PDT
Re-opening for pull request https://github.com/apple/WebKit/pull/23
Comment 5 EWS 2022-07-20 20:48:11 PDT
Committed 252432.20@safari-7614-branch (37dbd2747817): <https://commits.webkit.org/252432.20@safari-7614-branch>

Reviewed commits have been landed. Closing PR #23 and removing active labels.