Bug 242916 - builtins generator tests failing after 252554@main
Summary: builtins generator tests failing after 252554@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-19 13:17 PDT by Ryan Haddad
Modified: 2022-07-19 16:22 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-07-19 13:17:26 PDT 
After https://commits.webkit.org/252554@main landed, builtins generator tests started failing on the bots.

https://build.webkit.org/#/builders/365/builds/4979/steps/22/logs/stdio

Much of what shows up in the diffs is like:
+extern const JSC::ImplementationVisibility s_builtinPrototypeEveryCodeImplementationVisibility;
Comment 1 Radar WebKit Bug Importer 2022-07-19 13:17:35 PDT 
<rdar://problem/97277965>
Comment 2 Ryan Haddad 2022-07-19 13:21:07 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2560
Comment 3 EWS 2022-07-19 16:22:14 PDT 
Committed 252622@main (bfdbc24636c7): <https://commits.webkit.org/252622@main>

Reviewed commits have been landed. Closing PR #2560 and removing active labels.