Bug 242876 - [ews-build.webkit.org] Formally block PRs when ValidateSquashed fails
Summary: [ews-build.webkit.org] Formally block PRs when ValidateSquashed fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-18 17:29 PDT by Jonathan Bedard
Modified: 2022-07-19 06:48 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-07-18 17:29:00 PDT 
Right now, ValidateSquashed does not modify PRs or bugs when it fails. This makes it difficult for contributors to understand why their change was not landed. We should use our steps which modify commit-queue flags, merge-queue labels and comment on bugs/PRs to make it more clear to contributors why their change was not landed.
Comment 1 Radar WebKit Bug Importer 2022-07-18 17:29:41 PDT 
<rdar://problem/97229223>
Comment 2 Jonathan Bedard 2022-07-18 17:33:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2530
Comment 3 EWS 2022-07-19 06:48:33 PDT 
Committed 252597@main (4dfcc954e076): <https://commits.webkit.org/252597@main>

Reviewed commits have been landed. Closing PR #2530 and removing active labels.