WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
242876
[ews-build.webkit.org] Formally block PRs when ValidateSquashed fails
https://bugs.webkit.org/show_bug.cgi?id=242876
Summary
[ews-build.webkit.org] Formally block PRs when ValidateSquashed fails
Jonathan Bedard
Reported
2022-07-18 17:29:00 PDT
Right now, ValidateSquashed does not modify PRs or bugs when it fails. This makes it difficult for contributors to understand why their change was not landed. We should use our steps which modify commit-queue flags, merge-queue labels and comment on bugs/PRs to make it more clear to contributors why their change was not landed.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-07-18 17:29:41 PDT
<
rdar://problem/97229223
>
Jonathan Bedard
Comment 2
2022-07-18 17:33:22 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2530
EWS
Comment 3
2022-07-19 06:48:33 PDT
Committed
252597@main
(4dfcc954e076): <
https://commits.webkit.org/252597@main
> Reviewed commits have been landed. Closing PR #2530 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug