WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
242873
[ews-build.webkit.org] Check ownership of target branch
https://bugs.webkit.org/show_bug.cgi?id=242873
Summary
[ews-build.webkit.org] Check ownership of target branch
Jonathan Bedard
Reported
2022-07-18 16:03:36 PDT
If the branch a PR is targeting is owned by a different remote than the PR was made against, we shouldn't let merge-queue land the change. This is most relevant for branches that are actually owned by origin and remotes that may be non-public, as pushing to an origin-owned branch would either break syncing or publish changes that may be intended to remain hidden.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-07-18 16:03:53 PDT
<
rdar://problem/97225367
>
Jonathan Bedard
Comment 2
2022-07-18 16:14:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2528
Jonathan Bedard
Comment 3
2022-07-18 16:31:37 PDT
Pull request:
https://github.com/apple/WebKit/pull/16
EWS
Comment 4
2022-07-18 17:22:47 PDT
Committed
252584@main
(038c4c107f86): <
https://commits.webkit.org/252584@main
> Reviewed commits have been landed. Closing PR #2528 and removing active labels.
Jonathan Bedard
Comment 5
2022-07-19 13:24:13 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/2561
EWS
Comment 6
2022-07-19 13:47:08 PDT
Committed
252614@main
(59ee02e5c6f4): <
https://commits.webkit.org/252614@main
> Reviewed commits have been landed. Closing PR #2561 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug