Bug 242735 - Commit queue fails to land patch with changes to prepare-ChangeLog script
Summary: Commit queue fails to land patch with changes to prepare-ChangeLog script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 237581 246323
  Show dependency tree / graph
 
Reported: 2022-07-13 20:13 PDT by David Kilzer (:ddkilzer)
Modified: 2023-01-19 11:57 PST (History)
5 users (show)

See Also:

Attachments
Patch without test for EWS (1.69 KB, patch)
2022-07-14 09:16 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (16.79 KB, patch)
2022-07-15 14:08 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v3 (16.82 KB, patch)
2022-07-15 14:38 PDT, David Kilzer (:ddkilzer) 		jbedard: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (16.88 KB, patch)
2022-07-15 16:57 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-07-13 20:13:06 PDT 
Commit queue fails to land patch with changes to prepare-ChangeLog script.

See Bug 237581, Attachment 460877 [details]:
<https://bugs.webkit.org/show_bug.cgi?id=237581>

Specifically this failure:
<https://ews-build.webkit.org/#/builders/28/builds/22797>
Comment 1 David Kilzer (:ddkilzer) 2022-07-14 09:16:51 PDT 
Created attachment 460893 [details]
Patch without test for EWS
Comment 2 David Kilzer (:ddkilzer) 2022-07-15 14:08:18 PDT 
Created attachment 460934 [details]
Patch v2

Added test for the fix.  Also refactored existing tests to pull out common code.
Comment 3 David Kilzer (:ddkilzer) 2022-07-15 14:38:37 PDT 
Created attachment 460935 [details]
Patch v3
Comment 4 David Kilzer (:ddkilzer) 2022-07-15 14:42:46 PDT 
Comment on attachment 460935 [details]
Patch v3

New test passes!  Now up for review.
Comment 5 David Kilzer (:ddkilzer) 2022-07-15 14:49:45 PDT 
Comment on attachment 460935 [details]
Patch v3

Adding cq+ since all "services" tests passed.

I don't think this change even affects any other tests until it's deployed.
Comment 6 David Kilzer (:ddkilzer) 2022-07-15 16:57:09 PDT 
Created attachment 460944 [details]
Patch for landing
Comment 7 David Kilzer (:ddkilzer) 2022-07-15 16:57:57 PDT 
Comment on attachment 460944 [details]
Patch for landing

Tweaked the commit log message--not sure why these comments got lost.
Comment 8 EWS 2022-07-15 19:19:49 PDT 
Committed 252532@main (97dcaeae0581): <https://commits.webkit.org/252532@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460944 [details].
Comment 9 Radar WebKit Bug Importer 2022-07-15 19:20:19 PDT 
<rdar://problem/97106200>
Comment 10 David Kilzer (:ddkilzer) 2022-07-16 09:44:39 PDT 
This patch left the commit queue bubble in a weird state--the patch landed, but commit queue thought it didn't?!  Oh well.
Comment 11 Jonathan Bedard 2022-07-18 11:32:10 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/2515
Comment 12 EWS 2022-07-18 11:39:13 PDT 
Committed 252571@main (da71edd76bae): <https://commits.webkit.org/252571@main>

Reviewed commits have been landed. Closing PR #2515 and removing active labels.