Bug 242719 - Add push subscriptions to apsd ignore list if necessary
Summary: Add push subscriptions to apsd ignore list if necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-13 14:57 PDT by Ben Nham
Modified: 2022-07-13 21:02 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-07-13 14:57:41 PDT 
Currently, if a user changes the notification permission for an origin from Allow to Deny in the browser settings pane, we don't communicate this change to apsd. This means that pushes from this origin can continue to wake the device and induce battery drain even though the push will always be useless, as we bail out of running push event handlers early when we detect that an origin is missing the notification permission. We should fix this by adding topics associated with denied permissions to the apsd ignore list.
Comment 1 Ben Nham 2022-07-13 14:58:02 PDT 
<rdar://problem/91586206>
Comment 2 Ben Nham 2022-07-13 15:06:26 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2384
Comment 3 EWS 2022-07-13 21:02:28 PDT 
Committed 252434@main (94e15b227a3c): <https://commits.webkit.org/252434@main>

Reviewed commits have been landed. Closing PR #2384 and removing active labels.