Bug 242710 - [CMake] Wrong message about dependency between introspection and gi-docgen
Summary: [CMake] Wrong message about dependency between introspection and gi-docgen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Linux
: P2 Minor
Assignee: lisiwei
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-13 12:53 PDT by Adrian Perez
Modified: 2022-07-16 05:52 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-07-13 12:53:31 PDT 
In Source/cmake/OptionsWPE.cmake (and OptionsWPE.cmake) we have the following:

  find_package(GIDocgen)
  if (ENABLE_DOCUMENTATION AND NOT GIDocgen_FOUND)
      message(FATAL_ERROR "gi-docgen is needed for ENABLE_INTROSPECTION.")
  endif ()

when in reality the dependency is the other way around: introspection is needed
for the gi-docgen documentation generator.
Comment 1 lisiwei 2022-07-15 14:46:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2472
Comment 2 EWS 2022-07-16 05:51:54 PDT 
Committed 252538@main (85864ba4b069): <https://commits.webkit.org/252538@main>

Reviewed commits have been landed. Closing PR #2472 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-16 05:52:16 PDT 
<rdar://problem/97121238>