Bug 242694 - Add message check to WebPageProxy::requestAttachmentIcon
Summary: Add message check to WebPageProxy::requestAttachmentIcon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-13 09:03 PDT by Per Arne Vollan
Modified: 2022-07-15 19:50 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-07-13 09:03:24 PDT 
WebPageProxy::requestAttachmentIcon should only be called if the attachment element is enabled. Also, passing a full pathname when creating the icon for the attachment is not needed, it is sufficient to create a dummy filename with the same extension.
Comment 1 Per Arne Vollan 2022-07-13 09:04:23 PDT 
<rdar://96832034>
Comment 2 Per Arne Vollan 2022-07-13 09:07:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2364
Comment 3 EWS 2022-07-15 19:50:13 PDT 
Committed 252533@main (334993de44ee): <https://commits.webkit.org/252533@main>

Reviewed commits have been landed. Closing PR #2364 and removing active labels.