Bug 242631 - Optimize some array operations by bypassing Identifier creation/destruction
Summary: Optimize some array operations by bypassing Identifier creation/destruction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-11 23:18 PDT by Darin Adler
Modified: 2022-07-12 07:37 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-07-11 23:18:35 PDT 
Some array operations are unnecessarily converting array indices into identifiers. Apparently at some point someone refactored to handle 64-bit integers, and moved the conversion to Identifier too soon.
Comment 1 Darin Adler 2022-07-11 23:23:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2321
Comment 2 EWS 2022-07-12 07:36:31 PDT 
Committed 252380@main (0e5b5facb644): <https://commits.webkit.org/252380@main>

Reviewed commits have been landed. Closing PR #2321 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-12 07:37:18 PDT 
<rdar://problem/96884719>