Bug 242624 - Optimize AtomStringImpl::remove by skipping unnecessary string equality checks
Summary: Optimize AtomStringImpl::remove by skipping unnecessary string equality checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-11 17:55 PDT by Darin Adler
Modified: 2022-07-12 07:33 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-07-11 17:55:41 PDT 
Noticed that when AtomStringImpl removes a string from the atom string table, it does an equality check on the string instead of doing a pointer comparison. Easy to fix.
Comment 1 Darin Adler 2022-07-11 22:22:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2320
Comment 2 EWS 2022-07-12 07:32:47 PDT 
Committed 252379@main (d781022ac569): <https://commits.webkit.org/252379@main>

Reviewed commits have been landed. Closing PR #2320 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-12 07:33:15 PDT 
<rdar://problem/96884503>