WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
242616
[Make] Update build-jsc and build-webgpu to use workspace builds
https://bugs.webkit.org/show_bug.cgi?id=242616
Summary
[Make] Update build-jsc and build-webgpu to use workspace builds
Elliott Williams
Reported
2022-07-11 16:50:14 PDT
We default to workspace build for build-webkit since
https://commits.webkit.org/251501@main
. We should do the same for build-jsc and build-webgpu, which are the two users of `BuildSubproject.pm` logic that calls into Make. This does not strictly need to be done before switching all Make-based builds to default to workspace mode. However, doing this first means that: 1) We'll override the default workspace behavior to ensure that `build-jsc` and friends always use the open-source WebKit.xcworkspace 2) We avoid redundant `make` invocations once Make switches to workspace mode by default
Attachments
Add attachment
proposed patch, testcase, etc.
Elliott Williams
Comment 1
2022-07-11 17:06:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2312
Radar WebKit Bug Importer
Comment 2
2022-07-18 16:51:16 PDT
<
rdar://problem/97227552
>
EWS
Comment 3
2022-07-25 19:11:51 PDT
Committed
252809@main
(03af7beefb55): <
https://commits.webkit.org/252809@main
> Reviewed commits have been landed. Closing PR #2312 and removing active labels.
Elliott Williams
Comment 4
2022-07-26 21:25:06 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/2770
EWS
Comment 5
2022-07-26 22:40:56 PDT
Committed
252861@main
(2fe47ad4362f): <
https://commits.webkit.org/252861@main
> Reviewed commits have been landed. Closing PR #2770 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug