Bug 242597 - [Make] Can't set GCC_PREPROCESSOR_ADDITIONS since 252143@main
Summary: [Make] Can't set GCC_PREPROCESSOR_ADDITIONS since 252143@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-11 11:39 PDT by Elliott Williams
Modified: 2022-07-11 12:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-07-11 11:39:26 PDT 
https://commits.webkit.org/252143@main ("Stop passing build settings on the command line to avoid invalidating IDE builds") broke workflows where GCC_PREPROCESSOR_ADDITIONS is set from outside of the Makefile (like in `build-jsc`).
Comment 1 Elliott Williams 2022-07-11 11:46:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2296
Comment 2 EWS 2022-07-11 12:49:05 PDT 
Committed 252348@main (ab59fcd01122): <https://commits.webkit.org/252348@main>

Reviewed commits have been landed. Closing PR #2296 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-11 12:50:19 PDT 
<rdar://problem/96838065>