Bug 242586 - shadow-dom/nested-slot-remove-crash.html and other -crash tests are listed in resource-files.json
Summary: shadow-dom/nested-slot-remove-crash.html and other -crash tests are listed in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-10 21:30 PDT by Ryosuke Niwa
Modified: 2022-07-14 20:06 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-07-10 21:30:24 PDT 
I noticed that this test is never ran / found by WebKit's run-webkit-tests because it's listed as a resource file in resource-files.json.

What's up with that?
Comment 1 Ryosuke Niwa 2022-07-10 21:48:37 PDT 
Looks like this is a very old bug in TestParser.analyze_test. It can't determine the test type so returns None. find_importable_tests would then classify it as a potential resource file.
Comment 2 Ryosuke Niwa 2022-07-10 23:09:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2287
Comment 3 EWS 2022-07-11 12:51:43 PDT 
Committed 252350@main (d8b1589e4915): <https://commits.webkit.org/252350@main>

Reviewed commits have been landed. Closing PR #2287 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-07-11 12:52:18 PDT 
<rdar://problem/96838187>