Bug 242585 - Rewrite flaky document leak tests with testDocumentIsNotLeaked
Summary: Rewrite flaky document leak tests with testDocumentIsNotLeaked
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
: 146182 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-07-10 20:21 PDT by Fujii Hironori
Modified: 2022-07-12 10:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.87 KB, patch)
2022-07-10 20:28 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch for landing (22.87 KB, patch)
2022-07-12 00:51 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-07-10 20:21:39 PDT 
Rewrite flaky document leak tests with testDocumentIsNotLeaked

Some document leak tests are using internals.numberOfLiveDocuments() and flaky.

Bug 146182 – editing/selection/leak-document-with-selection-inside.html is flaky
Bug 190890 – [macOS Release WK1] Layout Test editing/selection/navigation-clears-editor-state.html is a flaky failure
Bug 215177 – [ macOS iOS wk2 Release] editing/selection/navigation-clears-editor-state.html is a flaky failure
Bug 226598 – [MacOS & iOS] animations/leak-document-with-css-animation.html is a flaky failure

224541@main added testDocumentIsNotLeaked for the document leak tests.
Comment 1 Fujii Hironori 2022-07-10 20:28:46 PDT 
Created attachment 460787 [details]
Patch
Comment 2 Ryosuke Niwa 2022-07-11 21:21:47 PDT 
Comment on attachment 460787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460787&action=review

> LayoutTests/fast/workers/worker-document-leak.html:39
> +                await waitForDoneMessage()

Missing semicolon at the end.
Comment 3 Fujii Hironori 2022-07-12 00:51:43 PDT 
Created attachment 460807 [details]
Patch for landing
Comment 4 EWS 2022-07-12 02:28:11 PDT 
Committed 252375@main (e0c7afc43de0): <https://commits.webkit.org/252375@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460807 [details].
Comment 5 Radar WebKit Bug Importer 2022-07-12 02:29:19 PDT 
<rdar://problem/96872567>
Comment 6 David Kilzer (:ddkilzer) 2022-07-12 10:43:57 PDT 
*** Bug 146182 has been marked as a duplicate of this bug. ***