Bug 242554 - Shall the workaround for llvm.37598 be removed?
Summary: Shall the workaround for llvm.37598 be removed?
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-09 06:15 PDT by 674815634
Modified: 2022-07-16 06:16 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description 674815634 2022-07-09 06:15:17 PDT 
I find a workaround for llvm.37598 in line 86 of mem.c:
https://github.com/WebKit/WebKit/blob/main/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/mem.c

// Windows doesn't really support weak symbols as of May 2019, and Clang on
// Windows will emit strong symbols instead. See
// https://bugs.llvm.org/show_bug.cgi?id=37598
#if defined(__ELF__) && defined(__GNUC__)
#define WEAK_SYMBOL_FUNC(rettype, name, args) \
  rettype name args __attribute__((weak));
#else
#define WEAK_SYMBOL_FUNC(rettype, name, args) static rettype(*name) args = NULL;
#endif

This compiler bug is already fixed: https://bugs.llvm.org/show_bug.cgi?id=37598
Shall these workarounds be removed?
Comment 1 Radar WebKit Bug Importer 2022-07-16 06:16:16 PDT 
<rdar://problem/97121791>