Bug 242450 - Web Inspector: Lazily create SourceCodeTextRange for search result objects
Summary: Web Inspector: Lazily create SourceCodeTextRange for search result objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-07 09:05 PDT by Patrick Angle
Modified: 2022-07-08 09:52 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2022-07-07 09:05:59 PDT 
Creating this object is expensive because it tracks changes to the source code, but we never take advantage of that tracking and just immediately use the info to create the title strings for search results. We also already notify users that they need to search again if content on the page changes.
Comment 1 Radar WebKit Bug Importer 2022-07-07 09:06:07 PDT 
<rdar://problem/96601780>
Comment 2 Patrick Angle 2022-07-07 10:12:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2174
Comment 3 EWS 2022-07-08 09:52:51 PDT 
Committed 252277@main (7fb9668bb2d3): <https://commits.webkit.org/252277@main>

Reviewed commits have been landed. Closing PR #2174 and removing active labels.