Bug 242418 - REGRESSION (r221177): Redundant icon fetching in the web process for file inputs
Summary: REGRESSION (r221177): Redundant icon fetching in the web process for file inputs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-06 20:14 PDT by Simon Fraser (smfr)
Modified: 2022-07-07 08:35 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-07-06 20:14:33 PDT 
In r221177 there was an inadvertent switching from `icon ? RequestIcon::No : RequestIcon::Yes` to `icon ? RequestIcon::Yes : RequestIcon::No` in what is now FileInputType::didCreateFileList(), which results in a redundant fetch of the file icon in the web process when the UI process already did this and supplied the icon.
Comment 1 Simon Fraser (smfr) 2022-07-06 20:19:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2148
Comment 2 EWS 2022-07-07 08:34:50 PDT 
Committed 252215@main (b58cec34fd85): <https://commits.webkit.org/252215@main>

Reviewed commits have been landed. Closing PR #2148 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-07 08:35:16 PDT 
<rdar://problem/96599764>