Bug 242269 - Rename 'imageAndSize' and 'image' as 'iconAndSize' and 'icon'
Summary: Rename 'imageAndSize' and 'image' as 'iconAndSize' and 'icon'
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: GoodFirstBug, InRadar
Depends on:
Blocks:
 
Reported: 2022-07-01 14:51 PDT by Per Arne Vollan
Modified: 2024-07-23 23:52 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-07-01 14:51:20 PDT 
Address review feedback in https://github.com/WebKit/WebKit/pull/1928:

This function WebPageProxy::iconForAttachment is confusing.

1) 'imageAndSize' and 'image' should be renamed to 'iconAndSize' and 'icon' since the type is IconAndSize and the data member is .icon.

2) 'size' should be part of the return value. It's super subtle that 'size' is an out parameter -- but only on one platform!

3) Look into creating an API test for this
Comment 1 Radar WebKit Bug Importer 2022-07-01 14:51:40 PDT 
<rdar://problem/96315732>
Comment 2 Karl Dubost 2024-07-23 23:51:04 PDT 
https://github.com/WebKit/WebKit/blob/6b7f7447287dd93b8742b5e24ab12047cf6edf48/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm#L356-L366


current code

RefPtr<WebCore::ShareableBitmap> WebPageProxy::iconForAttachment(const String& fileName, const String& contentType, const String& title, FloatSize& size)
{
#if PLATFORM(IOS_FAMILY)
    auto imageAndSize = RenderThemeIOS::iconForAttachment(fileName, contentType, title);
    auto image = imageAndSize.icon;
    size = imageAndSize.size;
#else
    auto image = RenderThemeMac::iconForAttachment(fileName, contentType, title);
#endif
    return convertPlatformImageToBitmap(image.get(), iconSize);
}


Adding GoodFirstBug