RESOLVED FIXED242258
[Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS 
https://bugs.webkit.org/show_bug.cgi?id=242258
Summary [Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS
Elliott Williams
Reported 2022-07-01 12:01:12 PDT
build-webkit recognizes features defined in FeatureList.pm and passes corresponding build settings to Xcode. Make, despite having a BUILD_WEBKIT_OPTIONS setting for developers to override, does not parse out feature flag arguments. As a result, if you want to pass a feature flag to Make, you have to know what the corresponding build setting is. You also need to know that build-webkit defines the build setting as own name (i.e. ENABLE_PDFJS=ENABLE_PDFJS) and not YES. We should fix this so that build-webkit --debug --pdfjs and make debug BUILD_WEBKIT_OPTIONS=--pdfjs pass the same settings.
Attachments
Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2022-07-01 12:11:52 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2004
EWS
Comment 2 2022-07-01 17:59:03 PDT
Committed 252082@main (97a065060b7d): <https://commits.webkit.org/252082@main> Reviewed commits have been landed. Closing PR #2004 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-07-01 18:00:14 PDT
<rdar://problem/96324453>
Note You need to log in before you can comment on or make changes to this bug.