Bug 242244 - crashlogs_unittest.py should have decorations instead of early returns
Summary: crashlogs_unittest.py should have decorations instead of early returns
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-01 05:04 PDT by Kimmo Kinnunen
Modified: 2022-07-08 05:05 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-07-01 05:04:56 PDT 
https://github.com/WebKit/WebKit/pull/1941
>Can we file a new bug for this file? Although unrelated to this change, we really should decorate these test declarations with something instead of having an early exit in the tests themselves like this.

    def test_find_all_log_darwin(self):
        if not SystemHost.get_default().platform.is_mac():
            return
Comment 1 Radar WebKit Bug Importer 2022-07-08 05:05:12 PDT 
<rdar://problem/96664178>