Bug 242220 - Remove the workaround for llvm.38289?
Summary: Remove the workaround for llvm.38289?
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-30 17:07 PDT by zhonghao
Modified: 2022-07-07 17:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zhonghao 2022-06-30 17:07:35 PDT 
I find a workaround for llvm38289:
https://github.com/WebKit/WebKit/blob/156d59fe06826ce27650093d1abfd566d9b667d4/Source/WTF/wtf/Int128.cpp
// Workaround for clang bug: https://bugs.llvm.org/show_bug.cgi?id=38289
// Casting from long double to uint64_t is miscompiled and drops bits.
// It is more work, so only use when we need the workaround.
static UInt128Impl MakeUInt128FromFloat(long double v) {...



The compiler bug is marked as fixed:https://bugs.llvm.org/show_bug.cgi?id=38289

Shall the workarounds be removed?
Comment 1 Alexey Proskuryakov 2022-06-30 19:21:15 PDT 
This code was only added to WebKit 8 months ago. Of course, the minimum Xcode version supported is higher by 1 since then. But I don't know if the current minimum version has the fix.
Comment 2 Radar WebKit Bug Importer 2022-07-07 17:08:14 PDT 
<rdar://problem/96635267>