RESOLVED FIXED242186
Web Inspector: REGRESSION (Bug 241817 ) Filter bars missing from Styles and Computed panels 
https://bugs.webkit.org/show_bug.cgi?id=242186
Summary Web Inspector: REGRESSION (Bug 241817 ) Filter bars missing from Styles and C...
Razvan Caliman
Reported 2022-06-30 06:44:47 PDT
Created attachment 460578 [details] Missing filter bars Regressed by Bug 241817 `Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:216` ``` this.contentView.element.classList.toggle("has-filter-bar", !!this._filterBar); ``` The check for the truthiness of `this._filterBar` always occurs before the member is assigned. It always returns false: `!!undefined === false`. `WI.GeneralStyleDetailsSidebarPanel._showPanel()` is called at the top of `WI.GeneralStyleDetailsSidebarPanel.initialLayout()` before `this._filterBar` is ever assigned.
Attachments
Missing filter bars (185.11 KB, image/png)
2022-06-30 06:44 PDT, Razvan Caliman 		no flags
Details
With filter bars (188.51 KB, image/png)
2022-06-30 06:52 PDT, Razvan Caliman 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-06-30 06:45:58 PDT
<rdar://problem/96215062>
Razvan Caliman
Comment 2 2022-06-30 06:52:18 PDT
Created attachment 460579 [details] With filter bars
Razvan Caliman
Comment 3 2022-06-30 07:13:22 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1946
EWS
Comment 4 2022-07-02 04:17:11 PDT
Committed 252093@main (27afcd755691): <https://commits.webkit.org/252093@main> Reviewed commits have been landed. Closing PR #1946 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.