Bug 242076 - [git-webkit] Fix branch_point computation
Summary: [git-webkit] Fix branch_point computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-28 12:02 PDT by Jonathan Bedard
Modified: 2022-06-28 16:56 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-06-28 12:02:49 PDT 
If we don't have anything committed, the branch_point should be HEAD. Additionally, computing the branch_point is relatively expensive, we can avoid this computation when we're rebasing because we know that the branch point is the tip of the branch we're rebasing on.
Comment 1 Radar WebKit Bug Importer 2022-06-28 12:02:58 PDT 
<rdar://problem/96080523>
Comment 2 Jonathan Bedard 2022-06-28 12:07:25 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1861
Comment 3 EWS 2022-06-28 16:56:41 PDT 
Committed 251934@main (b571cde426fc): <https://commits.webkit.org/251934@main>

Reviewed commits have been landed. Closing PR #1861 and removing active labels.